YJDH-789 | Migrate summer voucher serial numbers to actual foreign keys#3842
YJDH-789 | Migrate summer voucher serial numbers to actual foreign keys#3842karisal-anders merged 4 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...plications/migrations/0038_employersummervoucher__obsolete_unclean_serial_number_and_more.py
Fixed
Show fixed
Hide fixed
...plications/migrations/0038_employersummervoucher__obsolete_unclean_serial_number_and_more.py
Fixed
Show fixed
Hide fixed
...plications/migrations/0038_employersummervoucher__obsolete_unclean_serial_number_and_more.py
Fixed
Show fixed
Hide fixed
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3842.api.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://nuortenkesaseteli-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe employer result is failed for https://kesaseteli-pr3842.dev.hel.ninja 😿💢💥💥 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
force-pushed
the
YJDH-789-link-to-youth-voucher
branch
from
63d2f17 to
5e8679e
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3842.api.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe youth result is failed for https://nuortenkesaseteli-pr3842.dev.hel.ninja 😿💢💥💥 |
TestCafe employer result is failed for https://kesaseteli-pr3842.dev.hel.ninja 😿💢💥💥 |
karisal-anders
force-pushed
the
YJDH-789-link-to-youth-voucher
branch
from
5e8679e to
10e6442
Compare
backend/kesaseteli/applications/migrations/helpers/serial_number_foreign_keys.py
Dismissed
Show dismissed
Hide dismissed
backend/kesaseteli/applications/migrations/helpers/serial_number_foreign_keys.py
Dismissed
Show dismissed
Hide dismissed
backend/kesaseteli/applications/migrations/helpers/serial_number_foreign_keys.py
Fixed
Show fixed
Hide fixed
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3842.api.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://nuortenkesaseteli-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe employer result is failed for https://kesaseteli-pr3842.dev.hel.ninja 😿💢💥💥 |
karisal-anders
force-pushed
the
YJDH-789-link-to-youth-voucher
branch
from
10e6442 to
15d208b
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3842.api.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3842.api.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://nuortenkesaseteli-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3842.api.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3842.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
Make EmployerSummerVoucherAdmin work better with summer voucher serial numbers. Employer UI: - fix employer UI so it doesn't needlessly try to fetch_employee_data with invalid input. Using De Morgan it was evident the check !(a || b || c) <=> !a && !b && !c should actually be !a || !b || !c <=> !(a && b && c) instead - make the employer summer voucher input UI work so that one has to first find a youth summer voucher using the employee name and summer voucher serial number, or otherwise they can't continue - make the UI more straightforward by first only showing the parts that are required, nothing else - after succesfully fetching youth summer voucher data from the backend the UI no longer allows the user to edit the employee's name, social security number or the summer voucher serial number refs YJDH-789
karisal-anders
force-pushed
the
YJDH-789-link-to-youth-voucher
branch
from
badb6ec to
bec702a
Compare
|
YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3842.api.dev.hel.ninja 🚀🚀🚀 |
|
|
|
YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
YJDH-HELSINKILISA-API branch is deployed to platta: https://helsinkilisa-pr3842.api.dev.hel.ninja 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-pr3842.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://nuortenkesaseteli-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://kesaseteli-handler-ui-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
|
APPLICANT is deployed to platta: https://helsinkilisa-ui-pr3842.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3842.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr3842.dev.hel.ninja 😆🎉🎉🎉 |
3 participants
Description ✨
Migrate EmployerSummerVoucher's summer voucher serial numbers to
actual foreign keys.
Make the employer UI more straightforward by first only showing the parts
that are required, nothing else.
See commit message for more details.
Related
YJDH-789
Testing ⚗️
Automatic tests:
Manual testing:
NEXT_PUBLIC_MOCK_FLAG=Trueandcreating YouthSummerVoucher and YouthApplication objects with factories to find with the
fetch_employee_datafunction.Screenshots 📸
Additional notes 🗒️
Disabled employer UI browser tests that would need an actual YouthSummerVoucher
for them to work. Previously there was no real link between the EmployerSummerVoucher
and YouthSummerVoucher so the tests passed, but now as they do, and there's no match
in the database, they fail if run. Fixing them would need a way to either mock the data
or have it in the backend.